Impl NdIndex<IxDyn> for &Vec<Ix> and Vec<Ix> #1146
Open
+20
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I agree that it may be worth adding @bluss What do you think? Fwiw, this currently works with let mut a = ArrayD::<f32>::zeros(vec![1, 2]);
let index = vec![0, 0];
a[&*index] = 1.0;(Note the extra If Regarding the implementation -- I'd suggest converting to |
|
Many thanks for the comments. The PR now adds implementations for |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to improve the ergonomics of indexing dynamic dimension arrays.
Let's say we have:
(Of course, in practice, the number of dims is dynamic.)
Then currently we can't do
a[&index] = 1.0ora[index] = 1.0. Instead we seem to need to doThis change makes the first two methods of indexing possible.
I'm new to
ndarray, so there may be a discussion on this somewhere that I haven't seen. The new impls were created by copying the impl of &[Ix] (for &Vec) and by modifying the impl of &[Ix] (for Vec).I can add tests for this if it looks useful?